Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 9 May 2017 00:53:04 +0000 (UTC)
From: "Anthony Grasso (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12927301.1452008180000.159042.1494291184152@Atlassian.JIRA>
In-Reply-To: <JIRA.12927301.1452008180000@Atlassian.JIRA>
References: <JIRA.12927301.1452008180000@Atlassian.JIRA> <JIRA.12927301.1452008180757@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (CASSANDRA-10968) When taking snapshot,
 manifest.json contains incorrect or no files when column family has
 secondary indexes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 09 May 2017 00:53:09 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-10968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000186#comment-16000186 ] 

Anthony Grasso edited comment on CASSANDRA-10968 at 5/9/17 12:52 AM:
---------------------------------------------------------------------

Nice find [~Gerrrr]!

I have reviewed code changes and performed the following for all versions of the patch available (2.1, 2.2, 3.11).
- Tested as per the example given by [~Gerrrr].
- Ran unit test created in isolation using the following command.
{noformat}
ant testsome -Dtest.name=org.apache.cassandra.db.ColumnFamilyStoreTest -Dtest.methods=testSnapshotWithoutFlushWithSecondaryIndexes
{noformat}
- Ran unit tests for {{ColumnFamilyStoreTest}} using the following command.
{noformat}
ant test -Dtest.name=ColumnFamilyStoreTest
{noformat}

I have left a comment on the commits ([2.1.12 | https://github.com/Gerrrr/cassandra/commit/ef7ffcd757a4523387a8a078ea75f9c154715b01], [2.2.4 | https://github.com/Gerrrr/cassandra/commit/83e02225859d4e4b49e0c4d8cc8f0917952981aa], [3.11 | https://github.com/Gerrrr/cassandra/commit/735ba7b59e06ae06f8287daa0fd0bb04de22cbc0]) in relation to the new unit test. We will need make a fix to it before we commit this patch.


was (Author: anthony grasso):
Nice find [~Gerrrr]!

I have reviewed code changes and performed the following for all versions of the patch available (2.1, 2.2, 3.11).
- Tested as per the example given by [~Gerrrr].
- Ran unit test created in isolation using the following command.
{noformat}
ant testsome -Dtest.name=org.apache.cassandra.db.ColumnFamilyStoreTest -Dtest.methods=testSnapshotWithoutFlushWithSecondaryIndexes
{noformat}
- Ran unit tests for {{ColumnFamilyStoreTest}} using the following command.
{noformat}
ant test -Dtest.name=ColumnFamilyStoreTest
{noformat}

I have left a comment on the PR in relation to the new unit test. We will need make a fix to it before we commit this patch.

> When taking snapshot, manifest.json contains incorrect or no files when column family has secondary indexes
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10968
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10968
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Fred A
>            Assignee: Aleksandr Sorokoumov
>              Labels: lhf
>             Fix For: 2.1.12, 2.2.4, 3.11.0
>
>
> xNoticed indeterminate behaviour when taking snapshot on column families that has secondary indexes setup. The created manifest.json created when doing snapshot, sometimes contains no file names at all and sometimes some file names. 
> I don't know if this post is related but that was the only thing I could find:
> http://www.mail-archive.com/user%40cassandra.apache.org/msg42019.html


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org