cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-13521) Add configurable upper bound for validation executor threads
Date Thu, 11 May 2017 20:35:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007139#comment-16007139
] 

Jeff Jirsa edited comment on CASSANDRA-13521 at 5/11/17 8:34 PM:
-----------------------------------------------------------------

{code}
# Number of simultaneous repair validations to allow. Default is unbounded
# Values less than one are interpreted as unbounded (the default)
# concurrent_validations: -1
{code}

For consistency with other config values, can we use {{0}} for disabled/default? Your code
handles {{0}} the same as {{-1}}, but using {{0}} in the yaml would be nice.

Trivial spacing issue [here|https://github.com/bdeggleston/cassandra/commit/8630c9de6ec572ba4bf8f91b25869d0a5ec3a898#diff-b76a607445d53f18a98c9df14323c7ddR1370]






was (Author: jjirsa):
{code}
+# Number of simultaneous repair validations to allow. Default is unbounded
 +# Values less than one are interpreted as unbounded (the default)
 +# concurrent_validations: -1
 {code}

For consistency with other config values, can we use {{0}} for disabled/default? Your code
handles {{0}} the same as {{-1}}, but using {{0}} in the yaml would be nice.

Trivial spacing issue [here|https://github.com/bdeggleston/cassandra/commit/8630c9de6ec572ba4bf8f91b25869d0a5ec3a898#diff-b76a607445d53f18a98c9df14323c7ddR1370]





> Add configurable upper bound for validation executor threads
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-13521
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13521
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>             Fix For: 4.0
>
>
> CompactionManager.validationExecutor has no upper limit on the maximum number of threads
it can use. This could cause a node to become overwhelmed with simultaneous validation tasks
in some cases.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message