cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Blake Eggleston (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13458) Diag. Events: Add unit testing support
Date Sat, 06 May 2017 01:14:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999210#comment-15999210
] 

Blake Eggleston commented on CASSANDRA-13458:
---------------------------------------------

With regard to testing (and having just a high level understanding of what you're proposing
with the diagnostic events) I think they could be really helpful with unit testing, and in
some cases, more pragmatic than refactoring. Without more understanding of exactly what's
going on under the hood here though, it's hard for me to say for sure.  I have a feeling diagnostic
events will end up being really cool though, so I've pulled down your branch and will try
to spend some time reading through it over the next week or so.

> Diag. Events: Add unit testing support
> --------------------------------------
>
>                 Key: CASSANDRA-13458
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13458
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Testing
>            Reporter: Stefan Podkowinski
>            Assignee: Stefan Podkowinski
>
> Diagnostic events will improve unit testing by
> * providing test execution control instances based on CompletableFutures (see [PendingRangeCalculatorServiceTest.java|https://github.com/spodkowinski/cassandra/blob/WIP-13458/test/unit/org/apache/cassandra/gms/PendingRangeCalculatorServiceTest.java])

> * validate state and behavior by allowing you to inspect generated events (see [HintsServiceEventsTest.java|https://github.com/spodkowinski/cassandra/blob/WIP-13458/test/unit/org/apache/cassandra/hints/HintsServiceEventsTest.java])
> See included [testing.rst|https://github.com/spodkowinski/cassandra/blob/WIP-13458/doc/source/development/testing.rst#diagnostic-events-40]
draft for more details. Let me know if this would be useful for you as a developer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message