cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13397) Return value of CountDownLatch.await() not being checked in Repair
Date Mon, 08 May 2017 00:13:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000134#comment-16000134
] 

ASF GitHub Bot commented on CASSANDRA-13397:
--------------------------------------------

GitHub user grom358 opened a pull request:

    https://github.com/apache/cassandra/pull/109

    Backport CASSANDRA-13397

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/instaclustr/cassandra cameron_13397

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cassandra/pull/109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #109
    
----
commit bd49317cf8d406824e8be0b3a7c676a0a6bb95f9
Author: Alwyn Davis <alwyndav@gmail.com>
Date:   2016-09-30T00:44:22Z

    Test commit

commit 2f45b53ee590fbefd3d15382765466fe716675d0
Author: Sylvain Lebresne <sylvain@datastax.com>
Date:   2016-06-23T08:58:14Z

    Fixed conflicts

commit c64c6a80a5a56f517625197fb30154f2ad99c808
Author: Yuki Morishita <yukim@apache.org>
Date:   2016-08-03T14:34:27Z

    Release sstables of failed stream sessions only when outgoing transfers are finished
    
    Patch by Paulo Motta; reviewed by Yuki Morishita for CASSANDRA-11345

commit 7a7c219024128063fee1bac382b68b659f93ea66
Author: Paulo Motta <pauloricardomg@gmail.com>
Date:   2016-08-13T01:06:27Z

    Throw RuntimeException if starting transfer of already completed OutgoingFileMessage

commit 05e9f07723ef53eb4b31ea3543699d6260797e3f
Author: Marcus Eriksson <marcuse@apache.org>
Date:   2016-06-13T13:29:08Z

    Avoid missing sstables when getting the canonical sstables
    
    Patch by marcuse; reviewed by Stefania Alborghetti for CASSANDRA-11996

commit f258bab2954be32c7637c1ba936a11f1d500d52e
Author: Sylvain Lebresne <sylvain@datastax.com>
Date:   2016-07-25T14:35:33Z

    AssertionError with MVs on updating a row that isn't indexed due to a null value
    
    patch by Sylvain Lebresne; reviewed by Carl Yeksigian for CASSANDRA-12247

commit abdb8224a04a56a12a4b8ea6984d68f99234b2c8
Author: Alex Petrov <oleksandr.petrov@gmail.com>
Date:   2016-05-09T09:06:43Z

    Allow updating UDT nested in non-frozen map after ALTERing the UDT
    
    Patch by Alex Petrov; reviewed by jknighton for CASSANDRA-11604

commit 909dfa82a5576a4ff2274511009b569ce9e50cc9
Author: Edward Capriolo <edlinuxguru@gmail.com>
Date:   2016-06-10T15:45:57Z

    StorageService shutdown hook should use a volatile variable
    
    patch by Ed Capriolo; reviewed by Stefania Alborghetti for CASSANDRA-11984

commit 63c6e9b8efaf91f6782f674cf33a8db13dc40f57
Author: Sam Tunnicliffe <sam@beobal.com>
Date:   2016-06-24T10:47:25Z

    Ensure new CFS is initialized before adding to schema
    
    Patch by Sam Tunnicliffe; reviewed by Aleksey Yeschenko for
    CASSANDRA-12083

commit 97d9b149c1189b82f68216be8eeac5f67f92b711
Author: Alwyn <alwyn@instaclustr.com>
Date:   2016-10-06T04:24:00Z

    Fix for incorrect test case in CASSANDRA-11604

commit 34a71bc0ea1fd8f3378a7fa9a286010c09f44956
Author: Alwyn Davis <alwyndav@gmail.com>
Date:   2016-10-15T23:17:01Z

    Bumped version number

commit 9e922d358a6ce8175b6f303b69b3c84a229514db
Author: benbromhead <ben.bromhead@gmail.com>
Date:   2016-10-19T06:57:52Z

    Update README.asc
    
    Changed README to be our FAQ and text. Includes link to actual readme for apache cassandra

commit 5a5d54d2583f6402c67e2ec6cc822e7ac99650cd
Author: benbromhead <ben.bromhead@gmail.com>
Date:   2016-10-19T07:17:49Z

    Merge pull request #1 from benbromhead/patch-1
    
    Update README.asc

commit e36f435a5901a185c196ffb5a69bdebca5540444
Author: benbromhead <ben.bromhead@gmail.com>
Date:   2016-10-19T07:21:43Z

    Update README.asc
    
    Reworded a few things, fixed some typos

commit ca1d94eec089694998d71869246d19516a1ef487
Author: benbromhead <ben.bromhead@gmail.com>
Date:   2016-10-19T07:28:01Z

    Update README.asc
    
    added link to Instaclustr.com

commit 2d1c3f5ae2000899b74af91aaf883bf5690585c9
Author: benbromhead <ben.bromhead@gmail.com>
Date:   2016-10-19T17:38:16Z

    Update README.asc

commit 488d07eaae3489aaf5468aeffde7859957292f3f
Author: benbromhead <ben.bromhead@gmail.com>
Date:   2016-10-19T18:28:45Z

    Update README.asc
    
    a word

commit deb53f468fe27aeb65f9729937233ea8e954f123
Author: Yuki Morishita <yukim@apache.org>
Date:   2016-09-29T20:05:12Z

    Merge branch 'cassandra-3.0' into cassandra-3.7-instaclustr
    Fix merkle tree depth calculation
    
    Patch by Paulo Motta; Reviewed by Yuki Morishita for CASSANDRA-12580

commit e09f1abd7261d3372081b72713fa7e57ccc9d3cd
Author: Yuki Morishita <yukim@apache.org>
Date:   2016-10-20T14:47:36Z

    Fix unreleased resource sockets
    
    patch by Arunkumar M; reviewed by yukim for CASSANDRA-12330

commit 8405b187d5bbd7951fd7de409b9370bfe3f668cd
Author: Yuki Morishita <yukim@apache.org>
Date:   2016-10-20T14:45:28Z

    Fix unreleased resource sockets
    
    patch by Arunkumar M; reviewed by yukim for CASSANDRA-12329

commit 53ebca6850b58f9f8ff8f3e03b50d2c604fdfc3a
Author: Jeff Jirsa <jeff.jirsa@crowdstrike.com>
Date:   2016-10-19T01:11:17Z

    Correct log message for statistics of offheap memtable flush
    
    Patch by Kurt Greaves; Reviewed by Jeff Jirsa for CASSANDRA-12776

commit ab0b88621071ee820699af742eeef12b3dd9e75c
Author: Marcus Eriksson <marcuse@apache.org>
Date:   2016-10-21T07:03:31Z

    Don't skip sstables based on maxLocalDeletionTime
    
    Patch by Cameron Zemek; reviewed by marcuse for CASSANDRA-12765

commit 6e694e76a02fdd30ac73a46d07c55689ba5f93f5
Author: Jeff Jirsa <jeff.jirsa@crowdstrike.com>
Date:   2016-10-22T02:04:04Z

    Split consistent range movement flag correction
    
    Patch by Sankalp Kohli; Reviewed by Jeff Jirsa for CASSANDRA-12786

commit 86e6e4ba1ed414e4ace38c3e3c51a151e74c45bd
Author: Sylvain Lebresne <sylvain@datastax.com>
Date:   2016-07-20T12:29:16Z

    NullPointerExpception when reading/compacting table
    
    patch by Sylvain Lebresne; reviewed by Carl Yeksigian for CASSANDRA-11988

commit 0576db93629790247fcb8cf281e413635b656b1f
Author: Sylvain Lebresne <sylvain@datastax.com>
Date:   2016-07-29T10:36:40Z

    NullPointerException during compaction on table with static columns
    
    patch by Sylvain Lebresne; reviewed by Carl Yeksigian for CASSANDRA-12336

commit 030cc592e8cf1ddc4079fab4570407cb24b058f6
Author: Stefania Alborghetti <stefania.alborghetti@datastax.com>
Date:   2016-09-23T05:52:02Z

    Avoid sstable corrupt exception due to dropped static column
    
    Patch by Stefania Alborghetti; reviewed by Carl Yeksigian for CASSANDRA-12582

commit 2cd54679d0cb1f2e2ef7b8de7a16c13fd374461e
Author: Marcus Eriksson <marcuse@apache.org>
Date:   2016-06-23T07:46:00Z

    Don't try to get sstables for non-repairing column families
    
    Patch by marcuse; reviewed by Paulo Motta for CASSANDRA-12077

commit d7fc4873eed70f8923e87f15af83900598061962
Author: kgreav <kurt201@hotmail.com>
Date:   2016-11-21T01:44:24Z

    Merge pull request #3 from instaclustr/kurt_2
    
    Backports

commit f866272e2e9ba2f39bd480c986e4c0711c689044
Author: Kurt <kurt@instaclustr.com>
Date:   2016-11-21T01:49:11Z

    Bump version to 3.7.2

commit b5587f41e711b07a9392309c179c4d5746db1405
Author: Kurt <kurt@instaclustr.com>
Date:   2016-11-23T00:35:54Z

    Updated list of backports

----


> Return value of CountDownLatch.await() not being checked in Repair
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-13397
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13397
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Simon Zhou
>            Assignee: Simon Zhou
>            Priority: Minor
>             Fix For: 3.0.x
>
>         Attachments: CASSANDRA-13397-v1.patch
>
>
> While looking into repair code, I realize that we should check return value of CountDownLatch.await().
Most of the places that we don't check the return value, nothing bad would happen due to other
protection. However, ActiveRepairService#prepareForRepair should have the check. Code to reproduce:
> {code}
>     public static void testLatch() throws InterruptedException {
>         CountDownLatch latch = new CountDownLatch(2);
>         latch.countDown();
>         new Thread(() -> {
>             try {
>                 Thread.sleep(1200);
>             } catch (InterruptedException e) {
>                 System.err.println("interrupted");
>             }
>             latch.countDown();
>             System.out.println("counted down");
>         }).start();
>         latch.await(1, TimeUnit.SECONDS);
>         if (latch.getCount() > 0) {
>             System.err.println("failed");
>         } else {
>             System.out.println("success");
>         }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message