cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-13396) Cassandra 3.10: ClassCastException in ThreadAwareSecurityManager
Date Thu, 04 May 2017 15:59:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996968#comment-15996968
] 

Jeff Jirsa edited comment on CASSANDRA-13396 at 5/4/17 3:58 PM:
----------------------------------------------------------------

[~eugenefedoto] - two quick notes

1) In all three versions of your patch, we can't [throw|https://github.com/eugenefedoto/cassandra/commit/5957dd84aaa239d62f40aa4bf5f3159bf7a300d7#diff-30a3dbf7d783cf329b5fb28a8b14332eR110]
in {{ThreadAwareSecurityManager.java}} or we'll end up with the same problem we had before.

2) In your [StartupCheck|https://github.com/eugenefedoto/cassandra/commit/5957dd84aaa239d62f40aa4bf5f3159bf7a300d7#diff-a5df240149285ae528cdd3c41aa59360R419]
, the second log line (on L419) isn't necessary.

[~snazy] - Eugene is a new contributor, I've talked him through how to contribute offline
via email, and probably shaped his approach (notably, the {{instanceof}} check from Ed's patch
isn't sufficient, because if logback has been removed from the classpath, we'll throw a {{NoClassDefFoundError}}
instead). Given that, do you want to review? 


was (Author: jjirsa):
[~eugenefedoto] - two quick notes

1) In all three versions of your patch, we can't [throw|https://github.com/eugenefedoto/cassandra/commit/5957dd84aaa239d62f40aa4bf5f3159bf7a300d7#diff-30a3dbf7d783cf329b5fb28a8b14332eR110]
in {{ThreadAwareSecurityManager.java}} or we'll end up with the same problem we had before.

2) In your [StartupCheck|https://github.com/eugenefedoto/cassandra/commit/5957dd84aaa239d62f40aa4bf5f3159bf7a300d7#diff-a5df240149285ae528cdd3c41aa59360R419]
, the second log line (on L419) isn't necessary.

[~snazy] - Eugene is a new contributor, I've talked him through how to contribute offline
via email, and probably shaped his approach. Given that, do you want to review? 

> Cassandra 3.10: ClassCastException in ThreadAwareSecurityManager
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-13396
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13396
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Edward Capriolo
>            Assignee: Eugene Fedotov
>            Priority: Minor
>
> https://www.mail-archive.com/user@cassandra.apache.org/msg51603.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message