cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergio Bossa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10130) Node failure during 2i update after streaming can have incomplete 2i when restarted
Date Thu, 18 May 2017 11:12:04 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015593#comment-16015593
] 

Sergio Bossa commented on CASSANDRA-10130:
------------------------------------------

[~adelapena], the approach looks good to me, here is some specific feedback:

* Why executing the [preBuildTask|https://github.com/apache/cassandra/compare/trunk...adelapena:10130-trunk#diff-3f2c8994c4ff8748c3faf7e70958520dR389]
in another thread via {{executeBlocking}}, rather than just calling {{Runnable#run}}?

* Currently, {{buildIndexesBlocking}} will end up rebuilding *all* indexes even if just a
single one failed, because {{markIndexBuilt}} is called in bulk at the very end; I know this
is in line with the previous behaviour, but wouldn't it make sense to improve it in this issue?

* Do we have tests checking:
** Index status pre and post (re)building actions (create index, rebuild index).
** Index status upon index removal.
** Index status and automatic rebuild in case of failures.

> Node failure during 2i update after streaming can have incomplete 2i when restarted
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10130
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10130
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Coordination
>            Reporter: Yuki Morishita
>            Assignee: Andrés de la Peña
>            Priority: Minor
>
> Since MV/2i update happens after SSTables are received, node failure during MV/2i update
can leave received SSTables live when restarted while MV/2i are partially up to date.
> We can add some kind of tracking mechanism to automatically rebuild at the startup, or
at least warn user when the node restarts.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message