Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 604CE200C55 for ; Thu, 13 Apr 2017 09:14:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5EE81160B98; Thu, 13 Apr 2017 07:14:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A4F4A160B8B for ; Thu, 13 Apr 2017 09:14:44 +0200 (CEST) Received: (qmail 34320 invoked by uid 500); 13 Apr 2017 07:14:43 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 34309 invoked by uid 99); 13 Apr 2017 07:14:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Apr 2017 07:14:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 67E75CCE23 for ; Thu, 13 Apr 2017 07:14:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id mlSIkjiAGVL9 for ; Thu, 13 Apr 2017 07:14:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BF5845FDA3 for ; Thu, 13 Apr 2017 07:14:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 335C1E044B for ; Thu, 13 Apr 2017 07:14:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C084E20D54 for ; Thu, 13 Apr 2017 07:14:41 +0000 (UTC) Date: Thu, 13 Apr 2017 07:14:41 +0000 (UTC) From: "Robert Stupp (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-13443) V5 protocol flags decoding broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 13 Apr 2017 07:14:45 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Stupp updated CASSANDRA-13443: ------------------------------------- Fix Version/s: 4.0 3.11.0 > V5 protocol flags decoding broken > --------------------------------- > > Key: CASSANDRA-13443 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13443 > Project: Cassandra > Issue Type: Bug > Reporter: Robert Stupp > Assignee: Robert Stupp > Priority: Minor > Fix For: 3.11.0, 4.0 > > > Since native protocol version 5 we deserialize the flags in {{org.apache.cassandra.cql3.QueryOptions.Codec#decode}} as follows: > {code} > EnumSet flags = Flag.deserialize(version.isGreaterOrEqualTo(ProtocolVersion.V5) > ? (int)body.readUnsignedInt() > : (int)body.readByte()); > {code} > This works until the highest bit (0x80) is not used. {{readByte}} must be changed to {{readUnsignedByte}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)