Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Sat, 15 Apr 2017 00:53:41 +0000 (UTC)
From: "Michael Shuler (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13060816.1490997665000.288707.1492217621816@Atlassian.JIRA>
In-Reply-To: <JIRA.13060816.1490997665000@Atlassian.JIRA>
References: <JIRA.13060816.1490997665000@Atlassian.JIRA> <JIRA.13060816.1490997665672@jira-lw-us.apache.org>
Subject: [jira] [Updated] (CASSANDRA-13397) Return value of
 CountDownLatch.await() not being checked in Repair
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 15 Apr 2017 00:53:45 -0000


     [ https://issues.apache.org/jira/browse/CASSANDRA-13397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Shuler updated CASSANDRA-13397:
---------------------------------------
    Fix Version/s:     (was: 3.0.13)
                   3.0.x

> Return value of CountDownLatch.await() not being checked in Repair
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-13397
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13397
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Simon Zhou
>            Assignee: Simon Zhou
>            Priority: Minor
>             Fix For: 3.0.x
>
>         Attachments: CASSANDRA-13397-v1.patch
>
>
> While looking into repair code, I realize that we should check return value of CountDownLatch.await(). Most of the places that we don't check the return value, nothing bad would happen due to other protection. However, ActiveRepairService#prepareForRepair should have the check. Code to reproduce:
> {code}
>     public static void testLatch() throws InterruptedException {
>         CountDownLatch latch = new CountDownLatch(2);
>         latch.countDown();
>         new Thread(() -> {
>             try {
>                 Thread.sleep(1200);
>             } catch (InterruptedException e) {
>                 System.err.println("interrupted");
>             }
>             latch.countDown();
>             System.out.println("counted down");
>         }).start();
>         latch.await(1, TimeUnit.SECONDS);
>         if (latch.getCount() > 0) {
>             System.err.println("failed");
>         } else {
>             System.out.println("success");
>         }
>     }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)