Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 4 Apr 2017 10:28:41 +0000 (UTC)
From: "Benjamin Lerer (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13060674.1490967011000.199746.1491301721791@Atlassian.JIRA>
In-Reply-To: <JIRA.13060674.1490967011000@Atlassian.JIRA>
References: <JIRA.13060674.1490967011000@Atlassian.JIRA> <JIRA.13060674.1490967011907@jira-lw-us.apache.org>
Subject: [jira] [Updated] (CASSANDRA-13395) Expired rows without regular
 column data can crash upgradesstables
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 04 Apr 2017 10:28:47 -0000


     [ https://issues.apache.org/jira/browse/CASSANDRA-13395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Lerer updated CASSANDRA-13395:
---------------------------------------
    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed into 3.0 at 462b9cf63bf986671f8a080ef1802f0c27e7c772 and merged into 3.X.

> Expired rows without regular column data can crash upgradesstables
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-13395
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13395
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>
> In {{2.x}} if an expired row is compacted its row marker will be converted into a {{DeletedCell}}. In {{3.0}}, when the row is read by {{LegacyLayout}} it will be converted in a row without {{PrimaryKeyLivenessInfo}}. If the row does not contains any data for the regular columns, or if the table simply has no regular columns it will then be considered as {{empty}}. Which will crash {{upgradesstables}} with the following error:
> {code}
> java.lang.AssertionError
>         at org.apache.cassandra.db.rows.Rows.collectStats(Rows.java:70)
>         at org.apache.cassandra.io.sstable.format.big.BigTableWriter$StatsCollector.applyToRow(BigTableWriter.java:207)
>         at org.apache.cassandra.db.transform.BaseRows.applyOne(BaseRows.java:116)
>         at org.apache.cassandra.db.transform.BaseRows.add(BaseRows.java:107)
>         at org.apache.cassandra.db.transform.UnfilteredRows.add(UnfilteredRows.java:41)
>         at org.apache.cassandra.db.transform.Transformation.add(Transformation.java:156)
>         at org.apache.cassandra.db.transform.Transformation.apply(Transformation.java:122)
>         at org.apache.cassandra.io.sstable.format.big.BigTableWriter.append(BigTableWriter.java:147)
>         at org.apache.cassandra.io.sstable.SSTableRewriter.append(SSTableRewriter.java:125)
>         at org.apache.cassandra.db.compaction.writers.DefaultCompactionWriter.realAppend(DefaultCompactionWriter.java:57)
>         at org.apache.cassandra.db.compaction.writers.CompactionAwareWriter.append(CompactionAwareWriter.java:109)
>         at org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:195)
>         at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
>         at org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:89)
>         at org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:61)
>         at org.apache.cassandra.db.compaction.CompactionManager$5.execute(CompactionManager.java:416)
>         at org.apache.cassandra.db.compaction.CompactionManager$2.call(CompactionManager.java:308)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at org.apache.cassandra.concurrent.NamedThreadFactory.lambda$0(NamedThreadFactory.java:79)
>         at java.lang.Thread.run(Thread.java:745)
> {code}
> This problem is cause


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)