cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13455) lose check of null strings in decoding client token
Date Wed, 19 Apr 2017 04:54:42 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974071#comment-15974071
] 

Robert Stupp commented on CASSANDRA-13455:
------------------------------------------

Well, there's technically nothing wrong with empty passwords and people in the wild actually
use empty passwords. Therefore I doubt that the empty-password-check is feasible.
For the empty-username-check, I guess that's ok and does not harm. However, since it's impossible
to have a user/role with an empty name, the check seems to be superfluous in {{PasswordAuthenticator}}
- i.e. it would not do anything.

> lose check of null strings in decoding client token
> ---------------------------------------------------
>
>                 Key: CASSANDRA-13455
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13455
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: CentOS7.2
> Java 1.8
>            Reporter: Amos Jianjun Kong
>            Assignee: Amos Jianjun Kong
>             Fix For: 3.10
>
>         Attachments: 0001-auth-check-both-null-points-and-null-strings.patch, 0001-auth-strictly-delimit-in-decoding-client-token.patch
>
>
> RFC4616 requests AuthZID, USERNAME, PASSWORD are delimited by single '\000'.
> Current code actually delimits by serial '\000', when username or password
> is null, it caused decoding derangement.
> The problem was found in code review.
> ------------
> update: above description is wrong, the problem is that :
> When client responses null strings for username or password,
> current decodeCredentials() can't identify it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message