cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Eriksson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13257) Add repair streaming preview
Date Thu, 13 Apr 2017 11:34:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967447#comment-15967447
] 

Marcus Eriksson commented on CASSANDRA-13257:
---------------------------------------------

code LGTM, just a few small comments;
* {{\-p}} (short for {{--preview}}) clashes with {{-p}} for port
* logging - we should make it clear that we are doing a preview repair, perhaps replace the
prefix {{\[repair #{}\] ...}} with {{\[preview repair #{}\]}}?
* Use {{FBUtilities.prettyPrintMemory}} when displaying the result?
* Seems we still insert into {{system_distributed.repair_history}} in a few places during
a preview, we should probably avoid that
* Log the result as well as outputting it to stdout - if we ctrl+c the command we could still
read the result
* A few dtests running these new commands so we don't break them in the future

> Add repair streaming preview
> ----------------------------
>
>                 Key: CASSANDRA-13257
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13257
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Streaming and Messaging
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>             Fix For: 4.0
>
>
> It would be useful to be able to estimate the amount of repair streaming that needs to
be done, without actually doing any streaming. Our main motivation for this having something
this is validating CASSANDRA-9143 in production, but I’d imagine it could also be a useful
tool in troubleshooting.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message