cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mck (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session
Date Wed, 19 Apr 2017 02:32:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972551#comment-15972551
] 

mck edited comment on CASSANDRA-12835 at 4/19/17 2:32 AM:
----------------------------------------------------------

[~tjake], patches are updated here:
|| Branch 	|| Testall 	|| Dtest ||
| [3.11|https://github.com/michaelsembwever/cassandra/commit/4105fc71c652794d3ae1fba475f01ebf00199a07]
	| [testall|https://circleci.com/gh/michaelsembwever/cassandra/16] 	| [dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/15/]
|
| [trunk|https://github.com/michaelsembwever/cassandra/commit/c4de4f0dd0e70d7d67ade1e315ee3053494cf51c]
	| [testall|https://circleci.com/gh/michaelsembwever/cassandra/20] 	| [dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/19/]
|

(dtests are queued and will likely take some time to complete)


was (Author: michaelsembwever):
[~tjake], patches are updated here:
|| Branch 	|| Testall 	|| Dtest ||
| [3.11|https://github.com/michaelsembwever/cassandra/commit/4105fc71c652794d3ae1fba475f01ebf00199a07]
	| [testall|https://circleci.com/gh/michaelsembwever/cassandra/16] 	| [dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/15/]
|
| [trunk|https://github.com/michaelsembwever/cassandra/commit/c4de4f0dd0e70d7d67ade1e315ee3053494cf51c]
	| [testall|https://circleci.com/gh/michaelsembwever/cassandra/17] 	| [dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/19/]
|

(dtests are queued and will likely take some time to complete)

> Tracing payload not passed from QueryMessage to tracing session
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-12835
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Hannu Kröger
>            Assignee: mck
>            Priority: Critical
>              Labels: tracing
>             Fix For: 3.11.x, 4.x
>
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is QueryMessage and
the code in https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
is as follows:
> {code:java}
>             if (state.traceNextQuery())
>             {
>                 state.createTracingSession();
>                 ImmutableMap.Builder<String, String> builder = ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be {{state.createTracingSession(getCustomPayload());}}.
At least that fixes the problem for me.
> This also raises the question whether some other parts of the code should pass the custom
payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:    public void createTracingSession()
> 82:        createTracingSession(Collections.EMPTY_MAP);
> 85:    public void createTracingSession(Map<String,ByteBuffer> customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:            state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:                state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:                state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:                state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:                state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be fixed
by the tracing plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message