cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Eriksson (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
Date Wed, 12 Apr 2017 17:49:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966273#comment-15966273
] 

Marcus Eriksson edited comment on CASSANDRA-12661 at 4/12/17 5:49 PM:
----------------------------------------------------------------------

The problem is the order tests are run in, you change the static members of GCInspector in
one test, even if you create a new instance, those static members will have the same value

You should probably set/get the values in DatabaseDescriptor instead of copying them?


was (Author: krummas):
The problem is the order tests are run in, you change the static members of GCInspector in
one test, even if you create a new instance, those static members will have the same value

> Make gc_log and gc_warn settable at runtime
> -------------------------------------------
>
>                 Key: CASSANDRA-12661
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12661
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Minor
>         Attachments: Screen Shot 2017-04-12 at 11.38.06 AM.png
>
>
> Changes:
> * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in the config
> * rename variables to match properties
> * add unit tests to ensure hybration
> * add unit tests to ensure variables are set propertly
> * minor perf (do not consturct string from buffer f not logging)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message