cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-12661) Make gc_log and gc_warn settable at runtime
Date Wed, 12 Apr 2017 13:54:41 GMT


Edward Capriolo commented on CASSANDRA-12661:

it silently changes the default of gc_warn_threshold_in_ms from 0 to 1000

>From this one I do not believe this is the case. I believe the value was unset in the
config but statically set in the class. So it had a default value but it was not supplied
as thee other ones were.

due to the checks in the implementation, the order of calls to setGcLogThresholdInMs + setGcWarnThresholdInMs
depend on the current values, which should not be the case. this could be changed by having
just one method that changes both values.

That was the idea because one can not be lower then the other. I can see how this would be
problematic.We could simply set both or silently raise the value of one before the other.
Or do what you suggest.

i’m missing a reason for the new if (!mbs.isRegistered(me)) and the other change in the
static initializer

Running unit tests bark about instance already being registered. 

> Make gc_log and gc_warn settable at runtime
> -------------------------------------------
>                 Key: CASSANDRA-12661
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Minor
> Changes:
> * Move gc_log_threshold_in_ms and gc_warn_threshold_in_ms close together in the config
> * rename variables to match properties
> * add unit tests to ensure hybration
> * add unit tests to ensure variables are set propertly
> * minor perf (do not consturct string from buffer f not logging)

This message was sent by Atlassian JIRA

View raw message