Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0A3A0200C45 for ; Tue, 28 Mar 2017 14:49:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 08F12160B89; Tue, 28 Mar 2017 12:49:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4FF3C160B7E for ; Tue, 28 Mar 2017 14:49:51 +0200 (CEST) Received: (qmail 85437 invoked by uid 500); 28 Mar 2017 12:49:50 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 85426 invoked by uid 99); 28 Mar 2017 12:49:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Mar 2017 12:49:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 15553C6723 for ; Tue, 28 Mar 2017 12:49:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id sW_bNKnaDo0E for ; Tue, 28 Mar 2017 12:49:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F16675FBA1 for ; Tue, 28 Mar 2017 12:49:48 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 398C8E039D for ; Tue, 28 Mar 2017 12:49:48 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id F153325CF1 for ; Tue, 28 Mar 2017 12:49:41 +0000 (UTC) Date: Tue, 28 Mar 2017 12:49:41 +0000 (UTC) From: =?utf-8?Q?Andr=C3=A9s_de_la_Pe=C3=B1a_=28JIRA=29?= To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (CASSANDRA-13385) Delegate utests index name creation to CQLTester.createIndex MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 28 Mar 2017 12:49:52 -0000 Andr=C3=A9s de la Pe=C3=B1a created CASSANDRA-13385: --------------------------------------------- Summary: Delegate utests index name creation to CQLTester.crea= teIndex Key: CASSANDRA-13385 URL: https://issues.apache.org/jira/browse/CASSANDRA-13385 Project: Cassandra Issue Type: Improvement Components: Testing Reporter: Andr=C3=A9s de la Pe=C3=B1a Currently, many unit tests rely on {{CQLTester.createIndex}} to create inde= xes. The index name should be specified by the test itself, for example: {code} createIndex("CREATE CUSTOM INDEX myindex ON %s(c) USING 'org.apache.cassand= ra.index.internal.CustomCassandraIndex'"); {code} Two different tests using the same index name can produce racy {{Index myin= dex already exists}} errors due to the asynchronicity of {{CQLTester.afterT= est}} cleanup methods.=20 It would be nice to modify {{CQLTester.createIndex}} to make it generate it= own index names, as it is done by {{CQLTester.createTable}}: {code} createIndex("CREATE CUSTOM INDEX %s ON %s(c) USING 'org.apache.cassandra.in= dex.internal.CustomCassandraIndex'"); {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)