Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D8D8A200C44 for ; Mon, 27 Mar 2017 17:38:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D75D1160B9A; Mon, 27 Mar 2017 15:38:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2A20C160B5D for ; Mon, 27 Mar 2017 17:38:45 +0200 (CEST) Received: (qmail 16865 invoked by uid 500); 27 Mar 2017 15:38:44 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 16854 invoked by uid 99); 27 Mar 2017 15:38:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Mar 2017 15:38:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DF6A31A041E for ; Mon, 27 Mar 2017 15:38:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id G0-A2OB5Zwzk for ; Mon, 27 Mar 2017 15:38:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EEEF45FC6D for ; Mon, 27 Mar 2017 15:38:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4F315E088A for ; Mon, 27 Mar 2017 15:38:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A829A2406B for ; Mon, 27 Mar 2017 15:38:41 +0000 (UTC) Date: Mon, 27 Mar 2017 15:38:41 +0000 (UTC) From: "Jeremiah Jordan (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-13382) cdc column addition strikes again MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 27 Mar 2017 15:38:46 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-13382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943484#comment-15943484 ] Jeremiah Jordan commented on CASSANDRA-13382: --------------------------------------------- +1 Looks good to me. addViewToSchemaMutation calls addTableParamsToRowBuilder which was covered by the fix in CASSANDRA-12236. So the only MV cdc thing that still needs catching is in makeUpdateForSchema which this patch covers. > cdc column addition strikes again > --------------------------------- > > Key: CASSANDRA-13382 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13382 > Project: Cassandra > Issue Type: Bug > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Fix For: 3.11.x > > > This is a followup of CASSANDRA-12697, where the patch mistakenly only handled the {{system_schema.tables}} table, while the {{cdc}} column has been added to {{system_schema.views}} table. > The patch is pretty trivial, though this highlight that we don't seem to have upgrade tests for materialized views. -- This message was sent by Atlassian JIRA (v6.3.15#6346)