Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9B99F200C51 for ; Sat, 25 Mar 2017 19:19:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9A49A160B88; Sat, 25 Mar 2017 18:19:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E9F8B160B6F for ; Sat, 25 Mar 2017 19:19:45 +0100 (CET) Received: (qmail 99311 invoked by uid 500); 25 Mar 2017 18:19:45 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 99291 invoked by uid 99); 25 Mar 2017 18:19:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Mar 2017 18:19:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 75D7EC14D0 for ; Sat, 25 Mar 2017 18:19:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id TpZG0gWthc5n for ; Sat, 25 Mar 2017 18:19:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2FDDB5F5CA for ; Sat, 25 Mar 2017 18:19:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 28C9BE06CD for ; Sat, 25 Mar 2017 18:19:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9065524062 for ; Sat, 25 Mar 2017 18:19:41 +0000 (UTC) Date: Sat, 25 Mar 2017 18:19:41 +0000 (UTC) From: "Jeff Jirsa (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-13077) Add helper comments for unittest debug MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 25 Mar 2017 18:19:46 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941831#comment-15941831 ] Jeff Jirsa commented on CASSANDRA-13077: ---------------------------------------- Separate from the question of whether or not this is useful (it seems low risk, so low harm), is the patch correct? Are you adding the jvmarg beyond the closing tag of optargs ? > Add helper comments for unittest debug > -------------------------------------- > > Key: CASSANDRA-13077 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13077 > Project: Cassandra > Issue Type: Improvement > Components: Testing > Reporter: Jay Zhuang > Assignee: Jay Zhuang > Priority: Trivial > Fix For: 3.0.x > > Attachments: 13077-3.0.txt > > > Not an issue. Just add comments for future unittest debug. I find it useful, hope it could be merged: [13077-3.0.patch|https://github.com/cooldoger/cassandra/commit/91c98248a7c3427a22b564fc9e86691e7a923b95] -- This message was sent by Atlassian JIRA (v6.3.15#6346)