Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 30 Mar 2017 22:52:41 +0000 (UTC)
From: "Paulo Motta (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13021559.1479409568000.170232.1490914361726@Atlassian.JIRA>
In-Reply-To: <JIRA.13021559.1479409568000@Atlassian.JIRA>
References: <JIRA.13021559.1479409568000@Atlassian.JIRA> <JIRA.13021559.1479409568020@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (CASSANDRA-12929) dtest failure in
 bootstrap_test.TestBootstrap.simple_bootstrap_test_small_keepalive_period
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 30 Mar 2017 22:52:47 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-12929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950013#comment-15950013 ] 

Paulo Motta edited comment on CASSANDRA-12929 at 3/30/17 10:52 PM:
-------------------------------------------------------------------

Hmm, the version check {{CassandraVersion.isSupportedBy}} only consider versions in the same major compatible, so keep-alive was never being enabled. I updated the keep-alive version check to use {{compareTo}} which compares both majors and minors instead, which makes 4.0 compatible with 3.10.

Also updated dtest to use byteman so it will be faster [PR|https://github.com/riptano/cassandra-dtest/pull/1458]

Trivial patch attached:
||trunk||dtest||
|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-12929]|[branch|https://github.com/riptano/cassandra-dtest/compare/master...pauloricardomg:12929]|
|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-12929-dtest/lastCompletedBuild/testReport/]|


Mind having a quick look [~yukim]? Thanks!


was (Author: pauloricardomg):
Hmm, the version check {{CassandraVersion.isSupportedBy}} only consider versions in the same major compatible, so keep-alive was never being enabled. I updated the keep-alive version check to use {{compareTo}} which compares both majors and minors instead, which makes 4.0 compatible with 3.10.

Also updated dtest to use byteman so it will be faster [PR|https://github.com/riptano/cassandra-dtest/pull/1458]

Trivial patch attached:
||12929||dtest||
|[branch|https://github.com/apache/cassandra/compare/cassandra-12929...pauloricardomg:12929-trunk]|[branch|https://github.com/riptano/cassandra-dtest/compare/master...pauloricardomg:trunk]|
|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-12929-trunk-dtest/lastCompletedBuild/testReport/]|

Mind having a quick look [~yukim]? Thanks!

> dtest failure in bootstrap_test.TestBootstrap.simple_bootstrap_test_small_keepalive_period
> ------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12929
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12929
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Michael Shuler
>            Assignee: Paulo Motta
>              Labels: dtest, test-failure
>
> example failure:
> http://cassci.datastax.com/job/trunk_novnode_dtest/494/testReport/bootstrap_test/TestBootstrap/simple_bootstrap_test_small_keepalive_period
> {noformat}
> Error Message
> Expected [['COMPLETED']] from SELECT bootstrapped FROM system.local WHERE key='local', but got [[u'IN_PROGRESS']]
> -------------------- >> begin captured logging << --------------------
> dtest: DEBUG: cluster ccm directory: /tmp/dtest-YmnyEI
> dtest: DEBUG: Done setting configuration options:
> {   'num_tokens': None, 'phi_convict_threshold': 5, 'start_rpc': 'true'}
> cassandra.cluster: INFO: New Cassandra host <Host: 127.0.0.1 datacenter1> discovered
> --------------------- >> end captured logging << ---------------------
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
>     testMethod()
>   File "/home/automaton/cassandra-dtest/tools/decorators.py", line 46, in wrapped
>     f(obj)
>   File "/home/automaton/cassandra-dtest/bootstrap_test.py", line 163, in simple_bootstrap_test_small_keepalive_period
>     assert_bootstrap_state(self, node2, 'COMPLETED')
>   File "/home/automaton/cassandra-dtest/tools/assertions.py", line 297, in assert_bootstrap_state
>     assert_one(session, "SELECT bootstrapped FROM system.local WHERE key='local'", [expected_bootstrap_state])
>   File "/home/automaton/cassandra-dtest/tools/assertions.py", line 130, in assert_one
>     assert list_res == [expected], "Expected {} from {}, but got {}".format([expected], query, list_res)
> "Expected [['COMPLETED']] from SELECT bootstrapped FROM system.local WHERE key='local', but got [[u'IN_PROGRESS']]\n-------------------- >> begin captured logging << --------------------\ndtest: DEBUG: cluster ccm directory: /tmp/dtest-YmnyEI\ndtest: DEBUG: Done setting configuration options:\n{   'num_tokens': None, 'phi_convict_threshold': 5, 'start_rpc': 'true'}\ncassandra.cluster: INFO: New Cassandra host <Host: 127.0.0.1 datacenter1> discovered\n--------------------- >> end captured logging << ---------------------"
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)