cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13396) Cassandra 3.10: ClassCastException in ThreadAwareSecurityManager
Date Fri, 31 Mar 2017 16:25:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951215#comment-15951215
] 

Edward Capriolo commented on CASSANDRA-13396:
---------------------------------------------

{quote}
people would complain that C* is slow but don't realize it's in this case because of that
change. 
{quote}

First, its an obvious bug. The entire point of plug-gable logging implementations is so that
you can replace them. 
 
Second, the only person being actually affected would be Anton, because effective no one else
is changing logging implementations so no one else is hitting that block.

For Anton (and anyone else) they would have to manually change the files in the lib folder
and the configuration. So nothing is 'hidden' to him. He/They make a chance and they can report
if there actually is a performance issue.  

Because they can "scratch their itch" of running Cassandra in a container they might find
new problems or they might make new opportunities. For example, they may find that some other
implementation is actually better or faster. 

If anyone was actually trying to convince be that this bug is intentional, (which is almost
laughable). The proper practice would 

{code}
if (!logger instanceof XYZ){
  throw new IllegalArgumentException("we only support XYZ for reasons ABC");
}
{code}

But instead we are attempting to pretend the opposite that the bug is intentional and the
correct thing to do is throw a ClassCastException. 


> Cassandra 3.10: ClassCastException in ThreadAwareSecurityManager
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-13396
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13396
>             Project: Cassandra
>          Issue Type: Wish
>            Reporter: Edward Capriolo
>            Priority: Minor
>
> https://www.mail-archive.com/user@cassandra.apache.org/msg51603.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message