cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Lerer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13333) Cassandra does not start on Windows due to 'JNA link failure'
Date Thu, 23 Mar 2017 09:25:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937981#comment-15937981
] 

Benjamin Lerer commented on CASSANDRA-13333:
--------------------------------------------

[~mkjellman] Thanks for the reviews.

bq. 1. Should the loading of {{Native.register("winmm")}} in {{WindowsTimer}} also be moved
into NativeLibraryWindows?
{{WindowsTimer}} is really specific to Windows and according to [~JoshuaMcKenzie] [comment|https://issues.apache.org/jira/browse/CASSANDRA-13333?focusedCommentId=15929978&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15929978]
we should not prevent startup due to an inability to access the {{winmm.dll}} library. So,
I would be in favor of keeping it separeted for now.

bq. 2. Looks like the trunk patch didn't get pushed up or potentially just a copy paste error?
Currently it's just pointing at blerer/trunk.
Sorry for that. It is a copy paste mistake. I fixed it.

bq. 3.  Thanks for putting the MSDN API URL in the method javadoc.
I am pretty sure that otherwise, I will have to end up googling it in a month or two ;-) 

bq. 4. In NativeLibraryWindows I think the following logger statements could be simplified:
I have pushed a new commit to fix it in all the branches. 

> Cassandra does not start on Windows due to 'JNA link failure'
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-13333
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13333
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>            Priority: Blocker
>
> Cassandra 3.0 HEAD does not start on Windows. The only error in the logs is: 
> {{ERROR 16:30:10 JNA failing to initialize properly.}} 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message