cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-13297) Cleanup naming around native transport version parsing
Date Tue, 07 Mar 2017 14:06:38 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-13297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joshua McKenzie updated CASSANDRA-13297:
----------------------------------------
    Issue Type: Improvement  (was: Bug)

> Cleanup naming around native transport version parsing
> ------------------------------------------------------
>
>                 Key: CASSANDRA-13297
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13297
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Michael Kjellman
>
> While [~jasobrown] and myself were chasing down how features and versions are parsed
in the binary protocol, it took us a while to realize that the following check in StartupMessage
that creates a {{CassandraVersion}} object is actually parsing the *CQL* Version (but again..
with a class named {{CassandraVersion}}...)
> {code}
> if (new CassandraVersion(cqlVersion).compareTo(new CassandraVersion("2.99.0")) < 0)
> {code}
> It then turns out there is already a {{CqlVersion}} class that has some of what we want
but only appears to be being used by Stress.
> This isn't very clear so renaming the classes to make it obvious that we're parsing a
CQL Language version vs. the Cassandra Server version vs. the Binary Native Protocol version
will make this situation slightly better for people trying to contribute to the codebase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message