cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13257) Add repair streaming preview
Date Wed, 29 Mar 2017 05:01:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946527#comment-15946527
] 

Yuki Morishita commented on CASSANDRA-13257:
--------------------------------------------

Sorry for delay.
I think about {{PreviewKind}} again, and I'd like to keep that in repair.
The reason is that there is and will be a filtering logic that only gets executed when "previewing",
which sound weird to me since the logic never get called when not previewing. Right now the
only case is to validate repair. And for that, there is no need to preview streaming.

I think even so streaming preview covers both full and incremental repair case, and other
streaming usage.
My patch to move {{PreviewKind}} is here: https://github.com/yukim/cassandra/commit/55c3db065867c402bc4b1fc38ac0460854db6af6

For repair validation, {{SyncTask}} returns without invoking streaming preview. I think we
should add more info to {{SyncStat}}, as you left the note in TODO comment to give more information
for repair validation.

I also renamed {{PreviewKind}} to match repair options. as it gets displayed in repair command
output. Maybe implementing {{toString()}} is better though.

Other than that, I think overall well implemented. Thanks!

> Add repair streaming preview
> ----------------------------
>
>                 Key: CASSANDRA-13257
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13257
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Streaming and Messaging
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>             Fix For: 4.0
>
>
> It would be useful to be able to estimate the amount of repair streaming that needs to
be done, without actually doing any streaming. Our main motivation for this having something
this is validating CASSANDRA-9143 in production, but I’d imagine it could also be a useful
tool in troubleshooting.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message