cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Haddad (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13010) nodetool compactionstats should say which disk a compaction is writing to
Date Wed, 08 Mar 2017 01:39:38 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900539#comment-15900539
] 

Jon Haddad commented on CASSANDRA-13010:
----------------------------------------

On the nit side, I've already noticed a handful of cases that violate the style guide.  {
and } should always be on their own lines, even for single line functions.  

http://cassandra.apache.org/doc/latest/development/code_style.html#general-code-conventions

For instance:
CompactionInfo.java: targetDirectory() 
CompactionIterator.java: setTargetDirectory

There may be others, but I won't bother listing them (for now).  If you can take a pass &
ensure the patch conforms to the style guide, I'll focus on the content of the patch.

> nodetool compactionstats should say which disk a compaction is writing to
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13010
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13010
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jon Haddad
>            Assignee: Alex Lourie
>              Labels: lhf
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message