cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13237) Legacy deserializer can create unexpected boundary range tombstones
Date Mon, 20 Feb 2017 15:55:44 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874730#comment-15874730
] 

Sylvain Lebresne commented on CASSANDRA-13237:
----------------------------------------------

You're right, I didn't re-read the patch and botched it, sorry about that. I've pushed an
update to all branches that fixes both of your point in {{DataResolver}} (both were indeed
typos) and add a new test in {{DataResolverTest}} to test this.

I did rebased and force pushed the update mostly because I wanted the new test to be in the
first commit so I could easily test it with and without the fixes (crappy excuse, I know)
and I hope this isn't too much trouble (but I truly only did the changes of your points above).


> Legacy deserializer can create unexpected boundary range tombstones
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-13237
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13237
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 3.0.x, 3.11.x
>
>
> Most of the code don't generate a range tombstone boundary with the same deletion time
on both side as this is basically useless, and there is some assertion in {{DataResolver}}
that actually expect this. However, the deserializer for legacy sstable doesn't always properly
avoid their creation and we can thus generate them (and break the {{DataResolver}} assertion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message