cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-13217) minor bugs related to CASSANDRA-9143
Date Mon, 13 Feb 2017 23:37:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864681#comment-15864681
] 

Jeff Jirsa edited comment on CASSANDRA-13217 at 2/13/17 11:37 PM:
------------------------------------------------------------------

Looks like {{e1dda71}} ninja fixed the log ordering, so your log order fix isn't needed (because
Dave already flipped it for you). 


was (Author: jjirsa):
Looks like {{e1dda71}} ninja fixed the log ordering, so your flipping is wrong in this patch
(because Dave already flipped it for you). 

> minor bugs related to CASSANDRA-9143
> ------------------------------------
>
>                 Key: CASSANDRA-13217
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13217
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>
> We found a few minor bugs found in an internal review:
> * -incorrect log argument order [here|https://github.com/apache/cassandra/blob/edcbef3e343778b4d5affe019f64c89da2a13aa2/src/java/org/apache/cassandra/streaming/compress/CompressedStreamReader.java#L75]-
> * {{SSTableReader#intersects}} should use Bounds, not Range ([here|https://github.com/apache/cassandra/blob/edcbef3e343778b4d5affe019f64c89da2a13aa2/src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java#L1761])
> * {{CompactionStrategyManager#validateForCompaction}} doesn't prevent sstables from different
repair session from being compacted together [here|https://github.com/apache/cassandra/blob/edcbef3e343778b4d5affe019f64c89da2a13aa2/src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java#L1761]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message