cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13081) Confusing StreamReader.StreamDeserializer.cleanup leftover? code
Date Wed, 15 Feb 2017 15:30:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868031#comment-15868031
] 

Sylvain Lebresne commented on CASSANDRA-13081:
----------------------------------------------

Sure, and +1, but there is a {{if (deserializer != null)}} left in both {{StreamReader}} and
{{CompressedStreamReader}} (that guards the printing of a warning) that can go away too.

> Confusing StreamReader.StreamDeserializer.cleanup leftover? code
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-13081
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13081
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dave Brosius
>            Assignee: Paulo Motta
>            Priority: Trivial
>             Fix For: 4.x
>
>
> The cleanup method in StreamReader.StreamDeserializer does stuff in the cases when the
field 'in' is a RewindableDataInputStreamPlus typed object.
> Given that it is a 
>      this.in = new DataInputPlus.DataInputStreamPlus(in);
> that can never be. I'm assuming this was left over from some previous refactor or such.
Assuming we can just delete this?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message