cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12497) COPY ... TO STDOUT regression in 2.2.7
Date Tue, 07 Feb 2017 14:17:41 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856060#comment-15856060
] 

ASF GitHub Bot commented on CASSANDRA-12497:
--------------------------------------------

GitHub user salomvary opened a pull request:

    https://github.com/apache/cassandra/pull/92

    Fix failing COPY ... TO STDOUT

    Fixes [CASSANDRA-12497](https://issues.apache.org/jira/browse/CASSANDRA-12497).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/salomvary/cassandra fix-copy-to-stdout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cassandra/pull/92.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #92
    
----
commit 43b46a9cf2a4a190ce0e3b69ddddb1b21ddf1a10
Author: Márton Salomváry <salomvary@gmail.com>
Date:   2017-02-07T14:15:34Z

    Fix failing COPY ... TO STDOUT
    
    Fixed CASSANDRA-12497

----


> COPY ... TO STDOUT regression in 2.2.7
> --------------------------------------
>
>                 Key: CASSANDRA-12497
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12497
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Max Bowsher
>            Assignee: Tyler Hobbs
>
> Cassandra 2.2.7 introduces a regression over 2.2.6 breaking COPY ... TO STDOUT.
> In pylib/cqlshlib/copyutil.py, in CopyTask.__init__, self.printmsg is conditionally defined
to EITHER a module level function accepting arguments (msg, eol=, encoding=), OR a lambda
accepting arguments only (_, eol=).
> Consequently, when the lambda is in use (which requires COPY ... TO STDOUT without --debug),
any attempt to call CopyTask.printmsg with an encoding parameter causes an exception.
> This occurs in ExportTask.run, thus rendering all COPY ... TO STDOUT without --debug
broken.
> The fix is to update the lambda's arguments to include encoding, or better, replace it
with a module-level function defined next to printmsg, so that people realize the two argument
lists must be kept in sync.
> The regression was introduced in this commit:
> commit 5de9de1f5832f2a0e92783e2f4412874423e6e15
> Author: Tyler Hobbs <tylerlhobbs@gmail.com>
> Date:   Thu May 5 11:33:35 2016 -0500
>     cqlsh: Handle non-ascii chars in error messages
>     
>     Patch by Tyler Hobbs; reviewed by Paulo Motta for CASSANDRA-11626



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message