cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tylerho...@apache.org
Subject [03/15] cassandra git commit: Log full stack trace of uncaught exceptions
Date Wed, 22 Feb 2017 16:11:59 GMT
Log full stack trace of uncaught exceptions

Patch by Chris Batey; reviewed by Tyler Hobbs for CASSANDRA-13108


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3c2f8761
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3c2f8761
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3c2f8761

Branch: refs/heads/trunk
Commit: 3c2f87610de0f11071f3d5c005c1d14c06c832f8
Parents: de1f24d
Author: Chris Batey <christopher.batey@gmail.com>
Authored: Wed Feb 22 10:08:22 2017 -0600
Committer: Tyler Hobbs <tylerlhobbs@gmail.com>
Committed: Wed Feb 22 10:08:22 2017 -0600

----------------------------------------------------------------------
 CHANGES.txt                                                | 2 +-
 src/java/org/apache/cassandra/service/CassandraDaemon.java | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/3c2f8761/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 2266771..f3de538 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,5 +1,5 @@
 2.1.18
- * 
+ * Log stacktrace of uncaught exceptions (CASSANDRA-13108)
 
 2.1.17
  * Use portable stderr for java error in startup (CASSANDRA-13211)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/3c2f8761/src/java/org/apache/cassandra/service/CassandraDaemon.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/CassandraDaemon.java b/src/java/org/apache/cassandra/service/CassandraDaemon.java
index 5a1fb14..dc22834 100644
--- a/src/java/org/apache/cassandra/service/CassandraDaemon.java
+++ b/src/java/org/apache/cassandra/service/CassandraDaemon.java
@@ -228,7 +228,7 @@ public class CassandraDaemon
             public void uncaughtException(Thread t, Throwable e)
             {
                 StorageMetrics.exceptions.inc();
-                logger.error("Exception in thread {}", t, e);
+                logger.error("Exception in thread " + t, e);
                 Tracing.trace("Exception in thread {}", t, e);
                 for (Throwable e2 = e; e2 != null; e2 = e2.getCause())
                 {
@@ -237,7 +237,7 @@ public class CassandraDaemon
                     if (e2 instanceof FSError)
                     {
                         if (e2 != e) // make sure FSError gets logged exactly once.
-                            logger.error("Exception in thread {}", t, e2);
+                            logger.error("Exception in thread " + t, e2);
                         FileUtils.handleFSError((FSError) e2);
                     }
 


Mime
View raw message