cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Zhou (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13106) Unnecessary assertion
Date Fri, 06 Jan 2017 00:52:59 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15803059#comment-15803059
] 

Simon Zhou commented on CASSANDRA-13106:
----------------------------------------

Thanks [~dbrosius]. Yes, I do have -ea flag but doesn't that only cause ~5% performance degradation?

> Unnecessary assertion
> ---------------------
>
>                 Key: CASSANDRA-13106
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13106
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Simon Zhou
>            Assignee: Simon Zhou
>            Priority: Minor
>         Attachments: CASSANDRA-13106.patch
>
>
> We had over 70 thousand sstables and it's slow to bootstrap new node, even though the
CPU utilization for main thread of Cassandra was nearly 100%. So we took a few stack traces
and found that the main thread were busy running this line in Tracker.java:
> {code}
> assert Iterables.all(removed, remove);
> {code}
> Not exactly sure whether this line causes CPU utilization/bootstrapping issue, but this
line is redundant because the Predict we pass in is Predicates.<SSTableReader>alwaysTrue(),
which means the assertion always returns true. So I propose to remove that line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message