cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alain Rastoul (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13103) incorrect jvm metric names
Date Sun, 08 Jan 2017 10:53:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15809186#comment-15809186
] 

Alain Rastoul commented on CASSANDRA-13103:
-------------------------------------------

The problem has been introduced in 3.9, CASSANDRA-12312 : Add JVM metrics for custom metrics
reporter, 2016-07-26.

It should be present in cassandra-2.2, cassandra-3.0, cassandra-3.11, cassandra-3.X, trunk

I have attached a patch for 3.9 (and 3.X) which removes the unnecessary '.' and added a unit
test for jvm metrics registration.

I followed the 'How to contribute' wiki notes but was unable to assign myself the issue. 
May be an ASF member can tell me what to do or add me as assignable, in case I could work
on other LHF?
TIA




> incorrect jvm metric names
> --------------------------
>
>                 Key: CASSANDRA-13103
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13103
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Observability
>            Reporter: Alain Rastoul
>            Priority: Minor
>              Labels: lhf
>         Attachments: Fix-incorrect-jvm-metric-names-CASSANDRA-13103.patch
>
>
> Some jvm metrics have a double dot in name like:
> jvm.memory..total.max , jvm.memory..total.init (etc).
> it seems that an extra dot is added at the end of the name in CassandraDaemon.java, around
line 367 (in 3.0.10):
> ...
>                 // enable metrics provided by metrics-jvm.jar
>                 CassandraMetricsRegistry.Metrics.register("jvm.buffers.", new BufferPoolMetricSet(ManagementFactory.getPlatformMBeanServer()));
>                 CassandraMetricsRegistry.Metrics.register("jvm.gc.", new GarbageCollectorMetricSet());
>                 CassandraMetricsRegistry.Metrics.register("jvm.memory.", new MemoryUsageGaugeSet());
> and also added in append method of MetricRegistry.
> Call stack is:
> MetricRegistry>>registerAll(String prefix, MetricSet metrics)
> MetricRegistry>>static String name(String name, String... names)
> MetricRegistry>>static void append(StringBuilder builder, String part)
> and in append the dot is also added:
> ...
>             if(builder.length() > 0) {
>                 builder.append('.');
>             }
>             builder.append(part);
> ...
> The codahale MetricRegistry class seems to have no recent modification of name or append
methods, so it look like a small bug.
> May be the fix could be to simply not to add  the final dot in the metric name, ie  "jvm.buffers"
 instead of "jvm.buffers."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message