cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13084) Avoid byte-array copy when key cache is disabled
Date Tue, 03 Jan 2017 22:05:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796336#comment-15796336
] 

Jason Brown commented on CASSANDRA-13084:
-----------------------------------------

+1, committed as sha b137bd9778ca51cc30d2cfa290489b776951ca71 to 3.X and trunk

> Avoid byte-array copy when key cache is disabled
> ------------------------------------------------
>
>                 Key: CASSANDRA-13084
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13084
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Olsson
>            Assignee: Marcus Olsson
>            Priority: Trivial
>         Attachments: CASSANDRA-13084-3.0.patch, CASSANDRA-13084-3.X.patch
>
>
> While profiling a cluster with the key cache disabled some unnecessary heap pressure
was observed. It seems that even though the key cache is disabled we still create the *KeyCacheKey*
object which uses _ByteBufferUtil.getArray()_ to copy the keys byte array.
> I don't believe it's a big issue but it's still unnecessary when not using the key cache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message