cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-12997) dtest failure in org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName
Date Fri, 06 Jan 2017 14:27:58 GMT


Sylvain Lebresne commented on CASSANDRA-12997:

I think it's unfair to call it heavy-handed. The bulk of the patch is just passing {{QueryState}}
to {{announceMigration}}, which honestly we could well need for any other reason in the future
anyway. The only real change here is to use {{QueryState.getTimestamp()}} for the drop timestamp,
which is pretty trivial and is, I claim, TheRightThingToDoâ„¢, as the drop timestamp whole
point is to be compared to cell timestamps and thus by using the same generator for both is
just good hygiene. That's the important point here: I don't care about the test in practice,
but I think drop should have reused our usual way to generate timestamps for queries in the
first place, and it's high time we do this properly. Don't get me wrong, none of this is terribly
important, but I just don't want to focus on a crappy test when we can actually ever so slightly
improve the code.

> dtest failure in org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName
> -------------------------------------------------------------------------------------------------------------
>                 Key: CASSANDRA-12997
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sean McCarthy
>            Assignee: Sylvain Lebresne
>              Labels: test-failure, testall
> example failure:
> {code}
> Error Message
> Invalid value for row 0 column 2 (mycollection of type list<text>), expected <null>
but got <[first element]>
> {code}{code}Stacktrace
> junit.framework.AssertionFailedError: Invalid value for row 0 column 2 (mycollection
of type list<text>), expected <null> but got <[first element]>
> 	at org.apache.cassandra.cql3.CQLTester.assertRows(
> 	at org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(
> {code}

This message was sent by Atlassian JIRA

View raw message