cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12850) Add the duration type to the protocol V5
Date Thu, 26 Jan 2017 19:02:24 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840229#comment-15840229
] 

Tyler Hobbs commented on CASSANDRA-12850:
-----------------------------------------

+1, the new inner class solution is much cleaner.  I just have a couple of nitpicks/typo fixes
in the native protocol spec that can be fixed when committing:
* "The first [vint] represend a number of months, the second's a number of days and the last
a number of milliseconds."  It would be clearer to say this as "The first [vint] represents
a number of months, the second [vint] represents a number of days, and the last [vint] represents
a number of milliseconds".
* "equals to zero" should be "equal to zero" or just "zero".

> Add the duration type to the protocol V5
> ----------------------------------------
>
>                 Key: CASSANDRA-12850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12850
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: CQL
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>             Fix For: 3.x
>
>
> The Duration type need to be added to the protocol specifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message