cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay Zhuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12453) AutoSavingCache does not store required keys making RowCacheTests Flaky
Date Mon, 02 Jan 2017 22:19:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793601#comment-15793601
] 

Jay Zhuang commented on CASSANDRA-12453:
----------------------------------------

Thanks for the review.
Updated the patch.

> AutoSavingCache does not store required keys making RowCacheTests Flaky
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-12453
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12453
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: sankalp kohli
>            Assignee: Jay Zhuang
>            Priority: Minor
>             Fix For: 2.2.x, 3.0.x
>
>         Attachments: 12453-2.2-update.diff, 12453-2.2.txt
>
>
> RowCacheTests were flaky and while investigating, I found that it does not store all
the keys to disk. 
> The reason is that we use  OHCache and call hotKeyIterator on it. This is not guaranteed
to return the number of keys we want. Here is the documentation from OHCache 
> /**
>      * Builds an iterator over the N most recently used keys returning deserialized objects.
>      * You must call {@code close()} on the returned iterator.
>      * <p>
>      *     Note: During a rehash, the implementation might return keys twice or not at
all.
>      * </p>
>      */
>     CloseableIterator<K> hotKeyIterator(int n);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message