cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
Date Thu, 05 Jan 2017 12:57:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801294#comment-15801294
] 

Aleksey Yeschenko commented on CASSANDRA-10825:
-----------------------------------------------

bq. This feature never worked as intended. With this patch applied it will start doing something.
My concern is a user a user could suddenly start seeing OverloadedException and without the
metrics they will not have visibility into it.

That's a valid concern. Maybe we should just target trunk only here, to avoid surprising anyone
with new (old) behaviour? Would be indeed rude to drop it into 2.1/2.2/3.0 minor release,
with or without metrics. For trunk this is fine. Maybe even 3.X. wdyt?

> OverloadedException is untested
> -------------------------------
>
>                 Key: CASSANDRA-10825
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10825
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Ariel Weisberg
>            Assignee: Edward Capriolo
>         Attachments: jmx-hint.png
>
>
> If you grep test/src and cassandra-dtest you will find that the string OverloadedException
doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should back-pressure
and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test that it is
thrown under expected conditions. If there are behaviors driven by catching or tracking OverloadedException
we should test those as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message