cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-10825) OverloadedException is untested
Date Wed, 04 Jan 2017 22:21:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799526#comment-15799526
] 

Edward Capriolo edited comment on CASSANDRA-10825 at 1/4/17 10:21 PM:
----------------------------------------------------------------------

I realize that replacing AtomicLong with Counter and introducing metrics is beyond the scope
of the bug fix, but there is one thing I want to point out:

This feature never worked as intended. With this patch applied it will start doing something.
My concealer is a user a user could suddenly start seeing OverloadedException and without
the metrics they will not have visibility into it.

I do not mind breaking it out, but does that above rational change your opinion on breaking
it out?


was (Author: appodictic):
I realize that replacing AtomicLong with Counter and introducing metrics is beyond the scope
of the bug fix, but there is one thing I want to point out:

This feature never worked as intended. With this patch applied it will start doing something.
My concealer is a user A user could suddenly start seeing OverloadedException, and without
the metrics they will be unable to understand why.

I do not mind breaking it out, but does that above rational change your opinion on breaking
it out?

> OverloadedException is untested
> -------------------------------
>
>                 Key: CASSANDRA-10825
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10825
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Ariel Weisberg
>            Assignee: Edward Capriolo
>         Attachments: jmx-hint.png
>
>
> If you grep test/src and cassandra-dtest you will find that the string OverloadedException
doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should back-pressure
and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test that it is
thrown under expected conditions. If there are behaviors driven by catching or tracking OverloadedException
we should test those as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message