cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-10825) OverloadedException is untested
Date Tue, 03 Jan 2017 18:15:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795683#comment-15795683
] 

Aleksey Yeschenko edited comment on CASSANDRA-10825 at 1/3/17 6:15 PM:
-----------------------------------------------------------------------

Scratch that previous comment. It's just the only explanation that comes to mind, but cannot
be right.

Overall, though, I don't see any changes to the logic that would address the issue. Is all
you've done basically replace {{AtomicLong}} with {{Counter}} plus some unrelated minor refactorings?


was (Author: iamaleksey):
You are calling {{load}} with a new instance of autoboxed {{Integer}} every time, which is
why the increments seem 'lost'. In reality after two increment calls and one load call you
now have 3 instanced of {{AtomicInteger}} in the cache, two of 1 and one of 0.

> OverloadedException is untested
> -------------------------------
>
>                 Key: CASSANDRA-10825
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10825
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Ariel Weisberg
>            Assignee: Edward Capriolo
>         Attachments: jmx-hint.png
>
>
> If you grep test/src and cassandra-dtest you will find that the string OverloadedException
doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should back-pressure
and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test that it is
thrown under expected conditions. If there are behaviors driven by catching or tracking OverloadedException
we should test those as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message