Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2A11B200C04 for ; Tue, 20 Dec 2016 04:57:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 28DBE160B21; Tue, 20 Dec 2016 03:57:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6CFF7160B30 for ; Tue, 20 Dec 2016 04:56:59 +0100 (CET) Received: (qmail 12787 invoked by uid 500); 20 Dec 2016 03:56:58 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 12775 invoked by uid 99); 20 Dec 2016 03:56:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Dec 2016 03:56:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 54B992C0059 for ; Tue, 20 Dec 2016 03:56:58 +0000 (UTC) Date: Tue, 20 Dec 2016 03:56:58 +0000 (UTC) From: "Stefania (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CASSANDRA-13050) ReadCommand.CheckForAbort not monitoring CQL rows for range queries MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 20 Dec 2016 03:57:00 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-13050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763113#comment-15763113 ] Stefania edited comment on CASSANDRA-13050 at 12/20/16 3:56 AM: ---------------------------------------------------------------- I've fixed a few problems with the previous patch and I've multiplexed slow and aborted query tests 4 times with no failures: * http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/90 * http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/91 * http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/92 * http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/93 Proposed patch (it applies without conflicts to all branches): ||3.11||3.X||trunk|| |[patch|https://github.com/stef1927/cassandra/tree/13050-3.11]|[patch|https://github.com/stef1927/cassandra/tree/13050-3.X]|[patch|https://github.com/stef1927/cassandra/tree/13050]| |[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.11-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.X-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-testall/]| |[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.11-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.X-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-dtest/]| Dtests must run with this modified [branch|https://github.com/riptano/cassandra-dtest/compare/master...stef1927:13050] or some slow or aborted query tests may time out since we are now applying the test delay for every CQL row. Pull request for tests is [here|https://github.com/riptano/cassandra-dtest/pull/1413]. was (Author: stefania): I've fixed a few problems with the previous patch and I've multiplexed slow and aborted query tests 4 times with no failures: * http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/90 * http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/91 * http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/92 * http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-dtest-multiplex/93 Proposed patch (it applies without conflicts to all branches): ||3.11||3.X||trunk|| |[patch|https://github.com/stef1927/cassandra/tree/13050-3.11]|[patch|https://github.com/stef1927/cassandra/tree/13050-3.X]|[patch|https://github.com/stef1927/cassandra/tree/13050]| |[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.11-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.X-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-testall/]| |[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.11-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-3.X-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-13050-dtest/]| Dtests must run with modified dtest [branch|https://github.com/riptano/cassandra-dtest/compare/master...stef1927:13050] or else some slow or aborted query tests may time out since we are now applying the test delay for every CQL row. > ReadCommand.CheckForAbort not monitoring CQL rows for range queries > ------------------------------------------------------------------- > > Key: CASSANDRA-13050 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13050 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths > Reporter: Stefania > Assignee: Stefania > Fix For: 3.x > > > -If I understood the iterator transformations introduced by CASSANDRA-9975 correctly,- [ReadCommand.CheckForAbort|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/db/ReadCommand.java#L541] should apply itself before returning a partition. At the moment it is applied to row iterators for single command partitions, but for range queries -I think- it only monitors the query progress when a new partition is iterated, not when a new row is iterated. So for large partitions, we may fail to log a query as slow, or fail to abort it if the RPC timeout is exceeded. -- This message was sent by Atlassian JIRA (v6.3.4#6332)