Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7F873200BEA for ; Mon, 12 Dec 2016 20:51:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7E22C160B1A; Mon, 12 Dec 2016 19:51:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C61D1160B22 for ; Mon, 12 Dec 2016 20:50:59 +0100 (CET) Received: (qmail 88434 invoked by uid 500); 12 Dec 2016 19:50:58 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 88412 invoked by uid 99); 12 Dec 2016 19:50:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Dec 2016 19:50:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 63F502C03E0 for ; Mon, 12 Dec 2016 19:50:58 +0000 (UTC) Date: Mon, 12 Dec 2016 19:50:58 +0000 (UTC) From: "Robert Stupp (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-13033) Thread local pools never cleaned up MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 12 Dec 2016 19:51:00 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Stupp updated CASSANDRA-13033: ------------------------------------- Resolution: Fixed Fix Version/s: (was: 3.0.x) 3.10 3.0.11 Status: Resolved (was: Patch Available) Thanks for the prompt review! CI looks good - no failures related to this patch. Added the comment and committed it as [7f668c6fe117f892cd79863fb9805ea5d5a2823c|https://github.com/apache/cassandra/commit/7f668c6fe117f892cd79863fb9805ea5d5a2823c] to [cassandra-3.0|https://github.com/apache/cassandra/tree/cassandra-3.0] and merged it up to trunk. > Thread local pools never cleaned up > ----------------------------------- > > Key: CASSANDRA-13033 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13033 > Project: Cassandra > Issue Type: Bug > Reporter: Robert Stupp > Assignee: Robert Stupp > Fix For: 3.0.11, 3.10 > > > Netty 4.x uses {{(Fast)ThreadLocal}} instances to provide a pool of (direct) buffers per thread ({{io.netty.buffer.PooledByteBufAllocator.PoolThreadLocalCache}}. However, these per-thread pools need to be cleaned up when a thread terminates ({{FastThreadLocal.removeAll()}}) - which is missing. > Although the possibility that such per-thread pools ever _need_ to be cleaned up, since we rarely terminate threads, it still may actually happen and manifest in a late and hard to detect out-of-memory situation. One possibility to raise such a scenario is to regularly stop and restart the native protocol service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)