Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1138F200BEE for ; Sat, 31 Dec 2016 14:12:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0FAB7160B28; Sat, 31 Dec 2016 13:12:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7E772160B16 for ; Sat, 31 Dec 2016 14:11:59 +0100 (CET) Received: (qmail 35095 invoked by uid 500); 31 Dec 2016 13:11:58 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 35083 invoked by uid 99); 31 Dec 2016 13:11:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Dec 2016 13:11:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7BBA32C1F5A for ; Sat, 31 Dec 2016 13:11:58 +0000 (UTC) Date: Sat, 31 Dec 2016 13:11:58 +0000 (UTC) From: "Robert Stupp (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-12453) AutoSavingCache does not store required keys making RowCacheTests Flaky MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 31 Dec 2016 13:12:00 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Stupp updated CASSANDRA-12453: ------------------------------------- Reviewer: Robert Stupp > AutoSavingCache does not store required keys making RowCacheTests Flaky > ----------------------------------------------------------------------- > > Key: CASSANDRA-12453 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12453 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: sankalp kohli > Assignee: Jay Zhuang > Priority: Minor > Fix For: 2.2.x, 3.0.x > > Attachments: 12453-2.2.txt > > > RowCacheTests were flaky and while investigating, I found that it does not store all the keys to disk. > The reason is that we use OHCache and call hotKeyIterator on it. This is not guaranteed to return the number of keys we want. Here is the documentation from OHCache > /** > * Builds an iterator over the N most recently used keys returning deserialized objects. > * You must call {@code close()} on the returned iterator. > *

> * Note: During a rehash, the implementation might return keys twice or not at all. > *

> */ > CloseableIterator hotKeyIterator(int n); -- This message was sent by Atlassian JIRA (v6.3.4#6332)