cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CASSANDRA-13082) Suspect OnDiskIndex.IteratorOrder.startAt code for ASC
Date Wed, 28 Dec 2016 20:24:58 GMT
Dave Brosius created CASSANDRA-13082:
----------------------------------------

             Summary: Suspect OnDiskIndex.IteratorOrder.startAt code for ASC
                 Key: CASSANDRA-13082
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13082
             Project: Cassandra
          Issue Type: Bug
          Components: Core
            Reporter: Dave Brosius
            Priority: Trivial
             Fix For: 4.x


startAt for ASC does

                case ASC:
                    if (found.cmp < 0) // search term was bigger then whole data set
                        return found.index;
                    return inclusive && (found.cmp == 0 || found.cmp < 0) ? found.index
: found.index - 1;

which is equivalent to

                case ASC:
                    if (found.cmp < 0) // search term was bigger then whole data set
                        return found.index;
                    return inclusive ? found.index : found.index - 1;

which seems wrong. Is the parenthesis wrong here?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message