cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13050) ReadCommand.CheckForAbort not monitoring CQL rows for range queries
Date Thu, 22 Dec 2016 09:40:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15769607#comment-15769607
] 

Alex Petrov commented on CASSANDRA-13050:
-----------------------------------------

Thank you for the patch!

LGTM. As regards an error logging instead of assertion, as we have discussed offline, it might
be better to still keep assertions, as we may catch some bugs related to accidentally non-closed
partition. Also, other instances of {{StoppingTransformation}} are double-checked to make
sure we do close them.

There are some (most likely unrelated) dtest failures, so I've re-triggered a dtest trunk
build just to make sure.

> ReadCommand.CheckForAbort not monitoring CQL rows for range queries
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-13050
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13050
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Stefania
>            Assignee: Stefania
>             Fix For: 3.x
>
>
> -If I understood the iterator transformations introduced by CASSANDRA-9975 correctly,-
[ReadCommand.CheckForAbort|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/db/ReadCommand.java#L541]
should apply itself before returning a partition. At the moment it is applied to row iterators
for single command partitions, but for range queries -I think- it only monitors the query
progress when a new partition is iterated, not when a new row is iterated. So for large partitions,
we may fail to log a query as slow, or fail to abort it if the RPC timeout is exceeded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message