cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-13050) ReadCommand.CheckForAbort not monitoring CQL rows for range queries
Date Wed, 21 Dec 2016 04:15:58 GMT


Stefania commented on CASSANDRA-13050:

There were some failures in the unit and dtests, for example [here|].
They were caused by the fact that we no longer create a new stopping transformation when [applying
it to the partition|].
If the previous partition is not closed, then this assertion is triggered:

	at org.apache.cassandra.db.transform.StoppingTransformation.attachTo(
	at org.apache.cassandra.db.transform.BaseRows.add(
	at org.apache.cassandra.db.transform.UnfilteredRows.add(
	at org.apache.cassandra.db.transform.Transformation.add(
	at org.apache.cassandra.db.transform.Transformation.apply(
	at org.apache.cassandra.db.ReadCommand$CheckForAbort.applyToPartition(
	at org.apache.cassandra.db.ReadCommand$CheckForAbort.applyToPartition(
	at org.apache.cassandra.db.transform.BasePartitions.hasNext(
	at org.apache.cassandra.cql3.statements.SelectStatement.process(
	at org.apache.cassandra.cql3.statements.SelectStatement.processResults(
	at org.apache.cassandra.cql3.statements.SelectStatement.executeInternal(
	at org.apache.cassandra.cql3.statements.SelectStatement.executeInternal(
	at org.apache.cassandra.cql3.statements.SelectStatement.executeInternal(
	at org.apache.cassandra.cql3.QueryProcessor.executeInternal(
	at org.apache.cassandra.cql3.CQLTester.executeFormattedQuery(
	at org.apache.cassandra.cql3.CQLTester.execute(
	at org.apache.cassandra.cql3.SimpleQueryTest.restrictionOnRegularColumnWithStaticColumnPresentTest(

I fixed the failures by ensuring that the previous partition is closed, but the [assertion|]
in StoppingTransformation worries me a bit. We should perhaps change it into an error, along
with the [other one|]
for partition iterators.

> ReadCommand.CheckForAbort not monitoring CQL rows for range queries
> -------------------------------------------------------------------
>                 Key: CASSANDRA-13050
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Stefania
>            Assignee: Stefania
>             Fix For: 3.x
> -If I understood the iterator transformations introduced by CASSANDRA-9975 correctly,-
should apply itself before returning a partition. At the moment it is applied to row iterators
for single command partitions, but for range queries -I think- it only monitors the query
progress when a new partition is iterated, not when a new row is iterated. So for large partitions,
we may fail to log a query as slow, or fail to abort it if the RPC timeout is exceeded.

This message was sent by Atlassian JIRA

View raw message