cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-13040) Estimated TS drop-time histogram updated with Cell.NO_DELETION_TIME
Date Wed, 14 Dec 2016 01:26:58 GMT


Jason Brown commented on CASSANDRA-13040:

[~iksaif] so, are you saying this ticket has introduced a correctness bug or a performance
regression, or that you feel CASSANDRA-13038 (which I haven't looked at yet) will additionally
improve upon this patch?

> Estimated TS drop-time histogram updated with Cell.NO_DELETION_TIME
> -------------------------------------------------------------------
>                 Key: CASSANDRA-13040
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stefan Podkowinski
>            Assignee: Stefan Podkowinski
>             Fix For: 3.0.11, 3.10, 3.12, 4.0
>         Attachments: 13040-3.0.patch
> Starting with 3.0, {{MetadataCollector.updateLocalDeletionTime(int newLocalDeletionTime)}}
will be called with {{cell.localDeletionTime()}} in order to update the min/max deletion times
as well as the {{estimatedTombstoneDropTime}} histogram. Currently this also happens for {{Cell.NO_DELETION_TIME}}
({{Integer.MAX_VALUE}}), which causes the histogram to be called for every regular cell.
> This can be easily verified by using {{sstablemetadata}} on any sstable. You should be
able to find a very high value for 2147483647 in the "Estimated tombstone drop times" section.
> At this point, I don't think this is causing serious harm, but could be a performance
issue (see linked ticket). Calculated droppable TS times should not be affected.

This message was sent by Atlassian JIRA

View raw message