Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 36A51200BBB for ; Thu, 10 Nov 2016 17:56:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 35239160B11; Thu, 10 Nov 2016 16:56:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7BC58160AF7 for ; Thu, 10 Nov 2016 17:55:59 +0100 (CET) Received: (qmail 44332 invoked by uid 500); 10 Nov 2016 16:55:58 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 44316 invoked by uid 99); 10 Nov 2016 16:55:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Nov 2016 16:55:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 65B0C2C2B10 for ; Thu, 10 Nov 2016 16:55:58 +0000 (UTC) Date: Thu, 10 Nov 2016 16:55:58 +0000 (UTC) From: "Eduard Tudenhoefner (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CASSANDRA-12897) Move cqlsh syntax rules into separate module and allow easier customization MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 10 Nov 2016 16:56:00 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15653768#comment-15653768 ] Eduard Tudenhoefner edited comment on CASSANDRA-12897 at 11/10/16 4:55 PM: --------------------------------------------------------------------------- |[patch|https://github.com/nastra/cassandra/tree/CASSANDRA-12897]| |[testall|https://cassci.datastax.com/view/Dev/view/nastra/job/nastra-CASSANDRA-12897-testall/1/]| |[dtests|https://cassci.datastax.com/view/Dev/view/nastra/job/nastra-CASSANDRA-12897-dtest/1/]| was (Author: eduard.tudenhoefner): |[patch|https://github.com/nastra/cassandra/tree/CASSANDRA-12897]| |[testall|]| |[dtests|]| > Move cqlsh syntax rules into separate module and allow easier customization > --------------------------------------------------------------------------- > > Key: CASSANDRA-12897 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12897 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Eduard Tudenhoefner > Assignee: Eduard Tudenhoefner > Priority: Minor > Fix For: 3.x > > > At the moment the entire cqlsh syntax rules are defined in one single field in https://github.com/apache/cassandra/blob/13b7362494c4c0ff3c5ce80b8e7ee7fe64d65785/bin/cqlsh.py#L313-L426. > It would be easier if every syntax rule would be stored in its own field for easier extensibility / customizability. > It probably also makes sense to move the relevant *cqlsh* syntax rules and syntax completer into a separate *cqlshhandling.py* module because *cqlsh.py* in itself is huge. -- This message was sent by Atlassian JIRA (v6.3.4#6332)