cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Knighton (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-12792) delete with timestamp long.MAX_VALUE for the whole key creates tombstone that cannot be removed.
Date Thu, 17 Nov 2016 05:40:59 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-12792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joel Knighton updated CASSANDRA-12792:
--------------------------------------
    Status: Patch Available  (was: In Progress)

I've pushed rebased, updated branches and ran CI. CI looks clean relative to upstream. I made
your proposed fixes regarding hasTimestamp, null checking, and lambda usage in the 3.0+ branches.
While looking at the code, I realized that the {{PurgeEvaluator}} interface was no longer
necessary after an earier refactor and that comparable internals seem to use {{Predicate}}
directly. I adopted this approach in 2.2+ and changed the 2.2 branch to use anonymous classes,
since I thought this made it a little easier to follow. Let me know your thoughts on these
additional changes.

||branch||testall||dtest||
|[CASSANDRA-12792-2.2|https://github.com/jkni/cassandra/tree/CASSANDRA-12792-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-CASSANDRA-12792-2.2-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-CASSANDRA-12792-2.2-dtest]|
|[CASSANDRA-12792-3.0|https://github.com/jkni/cassandra/tree/CASSANDRA-12792-3.0]|[testall|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-CASSANDRA-12792-3.0-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-CASSANDRA-12792-3.0-dtest]|
|[CASSANDRA-12792-3.X|https://github.com/jkni/cassandra/tree/CASSANDRA-12792-3.X]|[testall|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-CASSANDRA-12792-3.X-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-CASSANDRA-12792-3.X-dtest]|
|[CASSANDRA-12792-trunk|https://github.com/jkni/cassandra/tree/CASSANDRA-12792-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-CASSANDRA-12792-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-CASSANDRA-12792-trunk-dtest]|


> delete with timestamp long.MAX_VALUE for the whole key creates tombstone that cannot
be removed. 
> -------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12792
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12792
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Ian Ilsley
>            Assignee: Joel Knighton
>
> In db/compaction/LazilyCompactedRow.java 
> we only check for  <  MaxPurgeableTimeStamp  
> eg:
> (this.maxRowTombstone.markedForDeleteAt < getMaxPurgeableTimestamp())
> this should probably be <= 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message