cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Knighton (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-12273) Casandra stress graph: option to create directory for graph if it doesn't exist
Date Thu, 10 Nov 2016 15:43:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654367#comment-15654367
] 

Joel Knighton edited comment on CASSANDRA-12273 at 11/10/16 3:43 PM:
---------------------------------------------------------------------

Very, very close - the only change is that the ticket number is included at the end of the
patch by ...; reviewed by ... line, like "patch by Murukesh Mohanan; reviewed by Joel Knighton
for CASSANDRA-12273" instead of including it at the end of the commit message. I might suggest
changing the message to something like "Create log/artifact directories as needed for stress,
handling symbolic links" to indicate that this changes behavior for the stress tool and not
the core DB.

{code}
Create log directories as needed, handling symbolic links

patch by Murukesh Mohanan; reviewed by Joel Knighton for CASSANDRA-12273
{code}

Thanks again.


was (Author: jkni):
Very, very close - the only change is that the ticket number is included at the end of the
patch by ...; reviewed by ... line, like "patch by Murukesh Mohanan; reviewed by Joel Knighton
for CASSANDRA-12273" instead of including it at the end of the commit message.

{code}
Create log directories as needed, handling symbolic links

patch by Murukesh Mohanan; reviewed by Joel Knighton for CASSANDRA-12273
{code}

Thanks again.

> Casandra stress graph: option to create directory for graph if it doesn't exist
> -------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12273
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12273
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Christopher Batey
>            Assignee: Murukesh Mohanan
>            Priority: Minor
>              Labels: lhf
>         Attachments: 12273.patch
>
>
> I am running it in CI with ephemeral workspace  / build dirs. It would be nice if CS
would create the directory so my build tool doesn't have to



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message