cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ZhaoYang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-12244) progress in compactionstats is reported wrongly for view builds
Date Sat, 05 Nov 2016 10:03:59 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

ZhaoYang updated CASSANDRA-12244:
---------------------------------
         Assignee: ZhaoYang
         Reviewer: Sylvain Lebresne
    Fix Version/s: 3.0.9
           Status: Patch Available  (was: Open)

1. change the compactionstats display to check if it's `bytes` unit before formating
2. added enum Unit - bytes, keys, ranges
3. change viewbuilder progress part to: first sort ranges then check num of ranges til last-built-token.


commit:
https://github.com/jasonstack/cassandra/commit/3fd19bc79fe5c8d6a0017e337296a702a5412173

> progress in compactionstats is reported wrongly for view builds
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-12244
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12244
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Tom van der Woerdt
>            Assignee: ZhaoYang
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.0.9
>
>
> In the view build progress given by compactionstats, there are several issues :
> {code}
>                                      id   compaction type   keyspace         table  
completed       total     unit   progress
>    038d3690-4dbe-11e6-b207-21ec388d48e6        View build      mykeyspace   mytable 
 844 bytes   967 bytes   ranges     87.28%
> Active compaction remaining time :        n/a
> {code}
> 1) those are ranges, not bytes
> 2) it's not at 87.28%, it's at ~4%. the method for calculating progress in Cassandra
is wrong: it neglects to sort the tokens it's iterating through (ViewBuilder.java) and thus
ends up with a random number.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message