Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 24 Oct 2016 15:15:58 +0000 (UTC)
From: =?utf-8?Q?Hannu_Kr=C3=B6ger_=28JIRA=29?= <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.13014757.1477321769000.68050.1477322158513@Atlassian.JIRA>
In-Reply-To: <JIRA.13014757.1477321769000@Atlassian.JIRA>
References: <JIRA.13014757.1477321769000@Atlassian.JIRA> <JIRA.13014757.1477321769899@arcas>
Subject: [jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from
 QueryMessage to tracing session
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 24 Oct 2016 15:16:05 -0000


     [ https://issues.apache.org/jira/browse/CASSANDRA-12835?page=3Dcom.atl=
assian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hannu Kr=C3=B6ger updated CASSANDRA-12835:
-------------------------------------
    Description:=20
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.

When querying using CQL statements (not prepared) the message type is Query=
Message and the code in https://github.com/apache/cassandra/blob/trunk/src/=
java/org/apache/cassandra/transport/messages/QueryMessage.java#L101 is as f=
ollows:
```
            if (state.traceNextQuery())
            {
                state.createTracingSession();

                ImmutableMap.Builder<String, String> builder =3D ImmutableM=
ap.builder();
```

`state.createTracingSession();` should probably be `state.createTracingSess=
ion(getCustomPayload());`. At least that fixes the problem for me.

This is not marked as `minor` as the CASSANDRA-11706 was because this canno=
t be fixed by the tracing plugin.

> Tracing payload not passed from QueryMessage to tracing session
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-12835
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1283=
5
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Hannu Kr=C3=B6ger
>            Priority: Critical
>              Labels: tracing
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is Que=
ryMessage and the code in https://github.com/apache/cassandra/blob/trunk/sr=
c/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101 is as=
 follows:
> ```
>             if (state.traceNextQuery())
>             {
>                 state.createTracingSession();
>                 ImmutableMap.Builder<String, String> builder =3D Immutabl=
eMap.builder();
> ```
> `state.createTracingSession();` should probably be `state.createTracingSe=
ssion(getCustomPayload());`. At least that fixes the problem for me.
> This is not marked as `minor` as the CASSANDRA-11706 was because this can=
not be fixed by the tracing plugin.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)