Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ED620200BA5 for ; Wed, 19 Oct 2016 09:26:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EBF31160AEA; Wed, 19 Oct 2016 07:26:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4047F160ADE for ; Wed, 19 Oct 2016 09:26:05 +0200 (CEST) Received: (qmail 95905 invoked by uid 500); 19 Oct 2016 07:25:58 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 95854 invoked by uid 99); 19 Oct 2016 07:25:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Oct 2016 07:25:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7CBE02C4C76 for ; Wed, 19 Oct 2016 07:25:58 +0000 (UTC) Date: Wed, 19 Oct 2016 07:25:58 +0000 (UTC) From: "Marcus Eriksson (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-12778) Tombstones not being deleted when only_purge_repaired_tombstones is enabled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 19 Oct 2016 07:26:06 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-12778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587918#comment-15587918 ] Marcus Eriksson commented on CASSANDRA-12778: --------------------------------------------- I imagine most of these issues will be solved by CASSANDRA-9143 > Tombstones not being deleted when only_purge_repaired_tombstones is enabled > --------------------------------------------------------------------------- > > Key: CASSANDRA-12778 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12778 > Project: Cassandra > Issue Type: Bug > Reporter: Arvind Nithrakashyap > Assignee: Marcus Eriksson > Priority: Critical > > When we use only_purge_repaired_tombstones for compaction, we noticed that tombstones are no longer being deleted. > {noformat}compaction = {'class': 'org.apache.cassandra.db.compaction.LeveledCompactionStrategy', 'only_purge_repaired_tombstones': 'true'}{noformat} > The root cause for this seems to be caused by the fact that repair itself issues a flush which in turn leads to a new sstable being created (which is not in the repair set). It looks like we do have some old data in this sstable because of this, only tombstones older than that timestamp are getting deleted even though many more keys have been repaired. > Fundamentally it looks like flush and repair can race with each other and with leveled compaction, the flush creates a new sstable at level 0 and removes the older sstable (the one that is picked for repair). Since repair itself seems to issue multiple flushes, the level 0 sstable never gets repaired and hence tombstones never get deleted. > We have already included the fix for CASSANDRA-12703 while testing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)